[sr-dev] git:5.5:f481071a: sipdump: fixed typo

[Henning Westerholt]

Content preview: Module: kamailio Branch: 5.5 Commit: f481071a671009f1dcc9fe5d36870e06edc2ec4b
URL: https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36870e06edc2ec4b
Author: Sergey Safarov <***@gmail.com> Committer: Henning Westerholt
<***@skalatan.de> Date: 2021-06-01T06:32:25Z

Content analysis details: (-3.7 points, 5.5 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager

Module: kamailio
Branch: 5.5
Commit: f481071a671009f1dcc9fe5d36870e06edc2ec4b
URL: https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36870e06edc2ec4b

Author: Sergey Safarov <***@gmail.com>
Committer: Henning Westerholt <***@skalatan.de>
Date: 2021-06-01T06:32:25Z

sipdump: fixed typo

(cherry picked from commit 7f226f5b08c93ed0a43113d7947730329ff7db38)

---

Modified: src/modules/sipdump/sipdump_mod.c

---

Diff: https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36870e06edc2ec4b.diff
Patch: https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36870e06edc2ec4b.patch

---

diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c
index 54b5c47484..0384458639 100644
--- a/src/modules/sipdump/sipdump_mod.c
+++ b/src/modules/sipdump/sipdump_mod.c
@@ -575,7 +575,7 @@ int pv_parse_sipdump_name(pv_spec_t *sp, str *in)
case 8:
if(strncmp(in->s, "src_port", 8)==0)
sp->pvp.pvn.u.isname.name.n = 8;
- if(strncmp(in->s, "dst_port", 8)==0)
+ else if(strncmp(in->s, "dst_port", 8)==0)
sp->pvp.pvn.u.isname.name.n = 9;
else goto error;
break;

[Olle E. Johansson]

Post by Henning Westerholt
Module: kamailio
Branch: 5.5
Commit: f481071a671009f1dcc9fe5d36870e06edc2ec4b
URL: https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36870e06edc2ec4b
Date: 2021-06-01T06:32:25Z
sipdump: fixed typo

That’s not a typo, that is a change in the logic (to be picky).

/O

Post by Henning Westerholt
(cherry picked from commit 7f226f5b08c93ed0a43113d7947730329ff7db38)
---
Modified: src/modules/sipdump/sipdump_mod.c
---
Diff: https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36870e06edc2ec4b.diff
Patch: https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36870e06edc2ec4b.patch
---
diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c
index 54b5c47484..0384458639 100644
--- a/src/modules/sipdump/sipdump_mod.c
+++ b/src/modules/sipdump/sipdump_mod.c
@@ -575,7 +575,7 @@ int pv_parse_sipdump_name(pv_spec_t *sp, str *in)
if(strncmp(in->s, "src_port", 8)==0)
sp->pvp.pvn.u.isname.name.n = 8;
- if(strncmp(in->s, "dst_port", 8)==0)
+ else if(strncmp(in->s, "dst_port", 8)==0)
sp->pvp.pvn.u.isname.name.n = 9;
else goto error;
break;
_______________________________________________
Kamailio (SER) - Development Mailing List
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-***@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mai

[Henning Westerholt]

Yes, but for such a small bug fix I do not wanted to do a manual commit just to fix the commit message.

--
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com

-----Original Message-----
From: sr-dev <sr-dev-***@lists.kamailio.org> On Behalf Of Olle E. Johansson
Sent: Tuesday, June 1, 2021 10:04 AM
To: Kamailio (SER) - Development Mailing List <sr-***@lists.kamailio.org>
Subject: Re: [sr-dev] git:5.5:f481071a: sipdump: fixed typo

Post by Henning Westerholt
Module: kamailio
Branch: 5.5
Commit: f481071a671009f1dcc9fe5d36870e06edc2ec4b
https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36
870e06edc2ec4b
Date: 2021-06-01T06:32:25Z
sipdump: fixed typo

That’s not a typo, that is a change in the logic (to be picky).

/O

Post by Henning Westerholt
(cherry picked from commit 7f226f5b08c93ed0a43113d7947730329ff7db38)
---
Modified: src/modules/sipdump/sipdump_mod.c
---
https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36
870e06edc2ec4b.diff
https://github.com/kamailio/kamailio/commit/f481071a671009f1dcc9fe5d36
870e06edc2ec4b.patch
---
diff --git a/src/modules/sipdump/sipdump_mod.c
b/src/modules/sipdump/sipdump_mod.c
index 54b5c47484..0384458639 100644
--- a/src/modules/sipdump/sipdump_mod.c
+++ b/src/modules/sipdump/sipdump_mod.c
@@ -575,7 +575,7 @@ int pv_parse_sipdump_name(pv_spec_t *sp, str *in)
if(strncmp(in->s, "src_port", 8)==0)
sp->pvp.pvn.u.isname.name.n = 8;
- if(strncmp(in->s, "dst_port", 8)==0)
+ else if(strncmp(in->s, "dst_port", 8)==0)
sp->pvp.pvn.u.isname.name.n = 9;
else goto error;
break;
_______________________________________________
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

_______________________________________________
Kamailio (SER) - Development Mailing List
sr-***@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-***@lists.kamailio.org
https://lists.kamailio.org/cgi