[sr-dev] git:master:4b7eedf5: secsipid: log message on identity generation failure

[Daniel-Constantin Mierla]

Content preview: Module: kamailio Branch: master Commit: 4b7eedf5af9a461d5a1de1148c814faa5db8cbaa
URL: https://github.com/kamailio/kamailio/commit/4b7eedf5af9a461d5a1de1148c814faa5db8cbaa
Author: Daniel-Constantin Mierla <***@gmail.com> Committer: Daniel-Constantin
Mierla <***@gmail.com> Date: 2021-05-31T15:02:01+02:00

Content analysis details: (-2.4 points, 5.5 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (miconda[at]gmail.com)
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is
CUSTOM_MED
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager

Module: kamailio
Branch: master
Commit: 4b7eedf5af9a461d5a1de1148c814faa5db8cbaa
URL: https://github.com/kamailio/kamailio/commit/4b7eedf5af9a461d5a1de1148c814faa5db8cbaa

Author: Daniel-Constantin Mierla <***@gmail.com>
Committer: Daniel-Constantin Mierla <***@gmail.com>
Date: 2021-05-31T15:02:01+02:00

secsipid: log message on identity generation failure

---

Modified: src/modules/secsipid/secsipid_mod.c

---

Diff: https://github.com/kamailio/kamailio/commit/4b7eedf5af9a461d5a1de1148c814faa5db8cbaa.diff
Patch: https://github.com/kamailio/kamailio/commit/4b7eedf5af9a461d5a1de1148c814faa5db8cbaa.patch

---

diff --git a/src/modules/secsipid/secsipid_mod.c b/src/modules/secsipid/secsipid_mod.c
index 30357a235e..18f962d362 100644
--- a/src/modules/secsipid/secsipid_mod.c
+++ b/src/modules/secsipid/secsipid_mod.c
@@ -327,6 +327,7 @@ static int ki_secsipid_add_identity(sip_msg_t *msg, str *origtn, str *desttn,
attest->s, origid->s, x5u->s, keypath->s, &ibody.s);

if(ibody.len<=0) {
+ LM_ERR("failed to get identity header body (%d)\n", ibody.len);
goto error;
}

@@ -526,9 +527,7 @@ static int secsipid_libopt_param(modparam_t type, void *val)
return -1;
}
sit->s = *((str*)val);
- if(secsipid_libopt_list!=NULL) {
- sit->next = secsipid_libopt_list;
- }
+ sit->next = secsipid_libopt_list;
secsipid_libopt_list = sit;

return 0;