[sr-dev] git:5.4:bde591dc: msrp: check return code for str explode

[Daniel-Constantin Mierla]

Content preview: Module: kamailio Branch: 5.4 Commit: bde591dc9507eaea0b744112d49ea01fbdf8f555
URL: https://github.com/kamailio/kamailio/commit/bde591dc9507eaea0b744112d49ea01fbdf8f555
Author: Daniel-Constantin Mierla <***@gmail.com> Committer: Daniel-Constantin
Mierla <***@gmail.com> Date: 2021-05-26T08:24:32+02:00

Content analysis details: (-2.4 points, 5.5 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is
CUSTOM_MED
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (miconda[at]gmail.com)
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager

Module: kamailio
Branch: 5.4
Commit: bde591dc9507eaea0b744112d49ea01fbdf8f555
URL: https://github.com/kamailio/kamailio/commit/bde591dc9507eaea0b744112d49ea01fbdf8f555

Author: Daniel-Constantin Mierla <***@gmail.com>
Committer: Daniel-Constantin Mierla <***@gmail.com>
Date: 2021-05-26T08:24:32+02:00

msrp: check return code for str explode

(cherry picked from commit addb6a88d0266a0bb0545077fb0b5b8a3fdcca8e)
(cherry picked from commit e55ecc6412997b55569f3b626a681eae0ca312df)

---

Modified: src/modules/msrp/msrp_parser.c

---

Diff: https://github.com/kamailio/kamailio/commit/bde591dc9507eaea0b744112d49ea01fbdf8f555.diff
Patch: https://github.com/kamailio/kamailio/commit/bde591dc9507eaea0b744112d49ea01fbdf8f555.patch

---

diff --git a/src/modules/msrp/msrp_parser.c b/src/modules/msrp/msrp_parser.c
index 4e5e67e130..7defaf9353 100644
--- a/src/modules/msrp/msrp_parser.c
+++ b/src/modules/msrp/msrp_parser.c
@@ -716,6 +716,11 @@ int msrp_parse_hdr_uri_list(msrp_hdr_t *hdr)
s = hdr->body;
trim(&s);
arr->size = msrp_explode_strz(&arr->list, &s, " ");
+ if(arr->size<0)
+ {
+ LM_ERR("failed to explode\n");
+ return -1;
+ }
hdr->parsed.flags |= MSRP_DATA_SET;
hdr->parsed.free_fn = msrp_str_array_destroy;
hdr->parsed.data = arr;