Discussion:
[sr-dev] git:master:79fbb7c6: pike: fixed regression
Daniel-Constantin Mierla
2021-05-26 06:05:40 UTC
Permalink
Content preview: Module: kamailio Branch: master Commit: 79fbb7c6df5d4c742b1283b752c2df0f51e77f09
URL: https://github.com/kamailio/kamailio/commit/79fbb7c6df5d4c742b1283b752c2df0f51e77f09
Author: Boris Korzun <***@miatel.ru> Committer: Daniel-Constantin Mierla
<***@gmail.com> Date: 2021-05-26T08:05:36+02:00

Content analysis details: (-2.4 points, 5.5 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is
CUSTOM_MED
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (miconda[at]gmail.com)
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager

Module: kamailio
Branch: master
Commit: 79fbb7c6df5d4c742b1283b752c2df0f51e77f09
URL: https://github.com/kamailio/kamailio/commit/79fbb7c6df5d4c742b1283b752c2df0f51e77f09

Author: Boris Korzun <***@miatel.ru>
Committer: Daniel-Constantin Mierla <***@gmail.com>
Date: 2021-05-26T08:05:36+02:00

pike: fixed regression
- removed unnecessary NULL-return from mark_node() after previous commit

---

Modified: src/modules/pike/ip_tree.c

---

Diff: https://github.com/kamailio/kamailio/commit/79fbb7c6df5d4c742b1283b752c2df0f51e77f09.diff
Patch: https://github.com/kamailio/kamailio/commit/79fbb7c6df5d4c742b1283b752c2df0f51e77f09.patch

---

diff --git a/src/modules/pike/ip_tree.c b/src/modules/pike/ip_tree.c
index c0324c0476..1fe9227a5f 100644
--- a/src/modules/pike/ip_tree.c
+++ b/src/modules/pike/ip_tree.c
@@ -301,10 +301,6 @@ pike_ip_node_t* mark_node(unsigned char *ip,int ip_len,
}
}

- if(node==NULL) {
- return NULL;
- }
-
LM_DBG("only first %d were matched!\n",byte_pos);
*flag = 0;
*father = 0;

Loading...