Discussion:
[sr-dev] [kamailio/kamailio] mtree: Missing docs of params "pv_dstid", "pv_weight", "pv_count" (#2750)
Olle E. Johansson
2021-05-28 07:30:10 UTC
Permalink
The mtree_mod.c file has three pv param settings that is not documented in the README
https://kamailio.org/docs/modules/devel/modules/mtree.html

* pv_dstid
* pv_count
* pv_weight

I see that pv_dstid and pv_weight is set in the code.

I can't really guess what they are, so I can't add docs myself...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2750
Olle E. Johansson
2021-05-28 07:36:21 UTC
Permalink
In addition I don't know if this is correct:
mtree_mod.c line 206

```
if(pv_parse_spec(&count_param, &pv_count) < 0
|| !(pv_is_w(&pv_weight)))
```
Should pv_weight be used there or pv_count?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2750#issuecomment-850216100
Daniel-Constantin Mierla
2021-05-28 08:29:43 UTC
Permalink
Hmm, these params seems to be from the initial version of the module, I even forgot about them, although git blames me from back in 2010. I will look into the code and document.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2750#issuecomment-850248398
Olle E. Johansson
2021-05-28 08:45:42 UTC
Permalink
Sometimes history gets back and starts hunting us...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2750#issuecomment-850257883
Daniel-Constantin Mierla
2021-05-29 13:57:09 UTC
Permalink
Should be now in master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2750#issuecomment-850837834
Daniel-Constantin Mierla
2021-05-29 13:57:10 UTC
Permalink
Closed #2750.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2750#event-4816071254
Loading...