Discussion:
[sr-dev] [kamailio/kamailio] pike: fixed regression (#2744)
Boris Korzun
2021-05-25 14:50:48 UTC
Permalink
#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
There's an regression in 5.5 on `pike.so`. After c9dc0336a33a0ecfe776975be7fbfab8f3c91b48 the module has stopped to work. `mark_node()` had returned a NULL on every IP-address.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/2744

-- Commit Summary --

* pike: fixed regression

-- File Changes --

M src/modules/pike/ip_tree.c (4)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2744.patch
https://github.com/kamailio/kamailio/pull/2744.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2744
Daniel-Constantin Mierla
2021-05-25 17:13:26 UTC
Permalink
Is this the fix for regression or just removal of an unnecessary return NULL? I understood from previous PR that the issues was with str case search.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2744#issuecomment-848059622
Boris Korzun
2021-05-25 20:05:09 UTC
Permalink
@miconda, yep, it's the fix for regression. Pike (`pike_check_req()`) doesn't work without the fix at all. :(

It has nothing to do with previous PR (str case search). I've investigated the regression and found two issues (str case search and unnecessary NULL-return).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2744#issuecomment-848223214
Daniel-Constantin Mierla
2021-05-26 06:05:49 UTC
Permalink
Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2744#issuecomment-848487444
Daniel-Constantin Mierla
2021-05-26 06:05:55 UTC
Permalink
Merged #2744 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2744#event-4796936597
Loading...