Discussion:
[sr-dev] [kamailio/kamailio] Update resolve.c handle type 41 (#2759)
Andrew Webster
2021-06-03 03:38:04 UTC
Permalink
Possible solution to https://github.com/kamailio/kamailio/issues/2758

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- Describe your changes in detail -->

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/2759

-- Commit Summary --

* Update resolve.c handle type 41

-- File Changes --

M src/core/resolve.c (1)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2759.patch
https://github.com/kamailio/kamailio/pull/2759.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2759
Henning Westerholt
2021-06-03 07:16:50 UTC
Permalink
Thanks for the pull request. This should already taken care of it in the current versions:

/*
* Older glibc < 2.25 does not include T_OPT in nameser_compat.h yet.
* On alpine linux musl library it is also not defined. There is no
* musl feature test macro, so we look for glibc instead.
*/
#if (defined __GLIBC__ && __GLIBC__ == 2 && __GLIBC_MINOR__ < 25) || !defined __GLIBC__
#ifndef T_OPT
#define T_OPT ns_t_opt
#endif
#endif

~/repositories/kamailio/src/core$ ack ns_t_opt /usr/include/arpa/nameser.h
ns_t_opt = 41,
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2759#issuecomment-853636302
Henning Westerholt
2021-06-03 07:22:11 UTC
Permalink
Closed #2759.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2759#event-4835801761
Loading...